Hello @dachary
The PR was closed with this comment
Will do, there's been a review from @lunny as well. Please see here
Apologies for the delay, I posted the comment on your behalf.
you have a reply from @zeripath, please see here
Apologies, I totally forgot about this PR. Your comments are ferried.
I created a PR on your behalf. As usual, it's in draft status pending your review. :)
PR's merged on GitHub!
I'm sorry, I totally forgot about this PR. Please ping me if I don't respond in 24h.
About the changes: when I try to apply the patch for the mentioned commit, I get this error:
00:00 atm@lab gitea ±|forgefriends-mr-52|→ curl https://lab.forgefriends.org/forgefriends/forgefriends/-/commit/33dc9895 | git am
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 111k 0 111k 0 0 22032 0 --:--:-- 0:00:05 --:--:-- 23604
Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To record the empty patch as an empty commit, run "git am --allow-empty".
To restore the original branch and stop patching, run "git am --abort".
Do I rebase against Gitea main, apply the mentioned commit and force push?
The PR has received a review from @gusted, kindly see here
Done! Please see here for the PR. As usual, the PR is in draft status pending your review. :)
closed as requested
There's new activity on the PR:
@go-gitea/mergers it looks like this PR can be merged. Or am I missing something?
@dachary there's new activity on the PR, please see https://github.com/go-gitea/gitea/pull/18446#issuecomment-1045966230
sure, done!
@Guested has left a review on the PR, please see https://github.com/go-gitea/gitea/pull/18446#pullrequestreview-882578346
@dachary: @KN4CK3R commented on this pull request, please see https://github.com/go-gitea/gitea/pull/18446#pullrequestreview-881766951