Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Forgefriends Forgefriends
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • forgefriendsforgefriends
  • ForgefriendsForgefriends
  • Merge requests
  • !54

Draft: test demonstrating orphaned process are not killed with their parent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Loïc Dachary requested to merge wip-daemon-bug into base-development Jun 14, 2022
  • Overview 19
  • Commits 8
  • Pipelines 7
  • Changes 10

PR: https://github.com/go-gitea/gitea/pull/20264


This test fails and demonstrates that when Gitea kills one of its children (for instance when mirroring a repository timesout), the grand children are not killed and become orphaned that linger and will eventually become zombies.

This is explained in detail in these blog posts:

  • https://hostea.org/blog/zombies/
  • https://hostea.org/blog/zombies-part-2/

I'd be happy to work on implementing a bug fix for Gitea.

...
[unit-test:115]         	            	  16511       1   16494 /usr/libexec/git-core/git remote-https origin https://4.4.4.4
[unit-test:116]         	            	  16513   16511   16494 /usr/libexec/git-core/git-remote-https origin https://4.4.4.4
...
[unit-test:120]         	            	  17165   16486       1 ps -x -o pid,ppid,pgid,args
[unit-test:121]         	            	Contains git-remote-https origin https://4.4.4.4
[unit-test:122]         	Test:       	TestManagerKillGrandChildren
[unit-test:123] FAIL
[unit-test:124] coverage: 35.5% of statements
[unit-test:125] FAIL	code.gitea.io/gitea/modules/process	6.518s
Edited Jul 14, 2022 by Loïc Dachary
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip-daemon-bug